Repository navigation
Conversation
This was referenced Sep 30, 2026
caugner
added this pull request to stack #558
October 1, 2026 02:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a separate field for visible inline
<code>spans, with exact syntax and identifier-prefix indexing.Motivation
Make technical syntax searchable while preserving existing prose recall and excluding
<pre>examples from inline-code relevance.Additional details
Dex builds the
mdn_docsindex; Rumba owns production search inmdn/rumba,src/api/search.rs::do_search. Fred calls/api/v1/search, which Dex proxies to Rumba. Rumba currently boosts title matches by 5 and body matches by 1, adding title phrase matches at 10 and body phrase matches at 2 for queries containing spaces. The defaultbestsort also adds popularity with a factor of 10 andboost_mode: sum.Add these clauses to Rumba's existing
subquerieslist, retaining the title, body, and phrase clauses:{ "term": { "inline_code.exact": { "value": "<query>", "boost": 20.0 } } } { "match": { "inline_code.partial": { "query": "<query>", "boost": 5.0 } } }Rumba's typed query serializer in
src/api/elastic.rsalso needs a term query variant and an inline-code partial match variant that serialize the dotted field names. The Dex index change alone does not change production matching or ranking until Rumba adds these clauses.Related issues and pull requests